Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use .call() to apply proper instance context + add unit spec tests fo… #121

Merged
merged 1 commit into from
Mar 17, 2018

Conversation

afixia
Copy link

@afixia afixia commented Mar 17, 2018

use hook callback.call method to apply proper 'this' context without changing hook parameters.

added unit tests for testing hooks and checking context

@kiaking
Copy link
Member

kiaking commented Mar 17, 2018

Thanks a lot! Very nice 👍

@kiaking kiaking merged commit 87f6e2a into master Mar 17, 2018
@kiaking kiaking deleted the patch/hook-context branch March 17, 2018 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants