VUFIND-1341 Remove deprecated methods #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* BrowseItem.setIds, BrowseItem.getIds (replaced by BrowseItem.getExtras/BrowseItem.setExtras) * BibDB.matchingIDs (superseded by with BibDB.matchingExtras)
|
@demiankatz I'm just knocking out a couple of deprecated methods here. Tests are still passing and no problems when testing locally either. |
1 task
demiankatz
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Thanks, @marktriggs -- I know I said that I would work on #48 first, but it occurred to me that it's actually easier to do the reverse. I've confirmed that this does not cause any problems for VuFind's test suite, so I'm going to merge it now. I can then combine all the changes from this and #48 into the binary updates to vufind-org/vufind#3253 and hopefully finish the remaining merging.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BrowseItem.setIds, BrowseItem.getIds (replaced by BrowseItem.getExtras/BrowseItem.setExtras)
BibDB.matchingIDs (superseded by with BibDB.matchingExtras)