Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VUFIND-1342 Update browse commands for new browse project layout #3253

Merged
merged 3 commits into from Dec 12, 2023

Conversation

marktriggs
Copy link
Contributor

@marktriggs marktriggs commented Dec 8, 2023

This is the companion commit to the changes in vufind-org/vufind-browse-handler#48

TODO

  • Finish and merge vufind-browse-handler PR, and then add the resulting binaries here before merging.
  • Update changelog when merging.

The vufind-browse-handler project has been restructured to use
packages in a more standard way.  Update class references to use
package-qualified names.
@demiankatz demiankatz added this to the 10.0 milestone Dec 8, 2023
@demiankatz demiankatz added the dependencies Pull requests that update a dependency file label Dec 8, 2023
Copy link
Member

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I've updated the binaries here to include the changes from vufind-org/vufind-browse-handler#48 and vufind-org/vufind-browse-handler#49, and I have confirmed that the index script works correctly in Windows and that the full test suite passes in Linux.

@demiankatz demiankatz merged commit e09f921 into dev Dec 12, 2023
10 checks passed
@demiankatz demiankatz deleted the VUFIND-1342 branch December 12, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
2 participants