Avoid error in MultiBackend driver when a hold has no id field. (#1999)

vufind-org · Jun 22, 2021 · adf9edc · adf9edc
1 parent 25b8e8f
commit adf9edc
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/module/VuFind/src/VuFind/ILS/Driver/MultiBackend.php b/module/VuFind/src/VuFind/ILS/Driver/MultiBackend.php
@@ -757,11 +757,14 @@ public function checkStorageRetrievalRequestIsValid($id, $data, $patron)
      */
     public function getPickUpLocations($patron = false, $holdDetails = null)
     {
-        $source = $this->getSource($patron['cat_username'] ?? $holdDetails['id']);
+        $source = $this->getSource(
+            $patron['cat_username'] ?? $holdDetails['id'] ?? $holdDetails['item_id']
+            ?? ''
+        );
         $driver = $this->getDriver($source);
         if ($driver) {
-            if ($holdDetails) {
-                if (!$this->driverSupportsSource($source, $holdDetails['id'])) {
+            if ($id = ($holdDetails['id'] ?? $holdDetails['item_id'] ?? '')) {
+                if (!$this->driverSupportsSource($source, $id)) {
                     // Return empty array since the sources don't match
                     return [];
                 }