Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid error in MultiBackend driver when a hold has no id field. #1999

Merged
merged 1 commit into from Jun 22, 2021

Conversation

EreMaijala
Copy link
Contributor

Since the id field is not mandatory, use item_id as fallback and handle gracefully the situation where neither exists. The error can be reproduced by setting

[Catalog]
idsInMyResearch = false

in Demo driver ini when MultiBackend is enabled and trying to edit holds.

@demiankatz
Copy link
Member

Makes sense to me! Thanks!

@demiankatz demiankatz merged commit adf9edc into vufind-org:dev Jun 22, 2021
@EreMaijala EreMaijala deleted the multibackend-hold-id-fix branch September 15, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants