Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First version Spanish es.ini with languages and call numbers translate. #1022

Closed
wants to merge 1 commit into from

Conversation

gcourault
Copy link
Contributor

Dear Sirs:
This is my contrib to the Spanish translate

@demiankatz
Copy link
Member

Thanks for sharing this. I have split up your work to two other places:

  • I have updated translation of language field in record-related templates #413 so that it includes your Spanish language name translations and so that it works correctly with the latest VuFind code (that PR had fallen quite out of date). We still need to decide on a strategy for which values we put in our language files before we can merge this, but at least your translations help make it easier to test the existing proof of concept.

  • I have created a new Turn on facet translation by default. #1023 which turns on facet translation by default for those fields where translation values are available (currently just format, with callnumber-first added thanks to your work here). We should discuss whether we want that to be the new default or not, but the new PR will capture your work and provide a place for discussion. Note that I created a new text domain called CallNumberFirstFacet for these values rather than putting them in the main language file. I think segregating facet translations into separate text domains will make the language files easier to manage.

Because all of the work from this PR has been moved to other places, I am going to close this one now. Thank you for sharing, and please feel free to comment on either or both of the other PRs referenced above.

@demiankatz demiankatz closed this Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants