Voyager: Implemented support for sorting holdings according to Voyager's... #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r's Holdings Sort Groups.
demiankatz
added a commit
that referenced
this pull request
Apr 8, 2014
Voyager: Implemented support for sorting holdings according to Voyager's...
oschihin
referenced
this pull request
in swissbib/vufind
Aug 14, 2014
* #131 * Informationen aufbereitet gemäss @mschwendener * Übersetzungen ausstehend, genaues Layout in Tabellenzeile Status
oschihin
referenced
this pull request
in swissbib/vufind
Aug 14, 2014
* #131 * Informationen aufbereitet gemäss @mschwendener * Übersetzungen ausstehend, genaues Layout in Tabellenzeile Status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... Holdings Sort Groups.
Since Voyager's Holdings Sort Groups can be used to define the order of locations in WebVoyage, it makes sense to follow the same ordering in VuFind. I don't see any reason for not doing this, but I included a setting that allows to disable the sorting if necessary.
With this change it became necessary to do both SQL queries for getStatus too (as discussed when implementing the same for getHolding...), as a location without items (such as "Online") may have a higher priority than a location with items.