Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgres-installer #143

Closed
wants to merge 4 commits into from
Closed

postgres-installer #143

wants to merge 4 commits into from

Conversation

jochen-lienhard
Copy link
Contributor

Hi,

this is my first pull request, so please excuse if I make some mistakes.

I added a new sql-file (pgsql.sql) that should replace postgres.sql. This file has a bug, some hidden
character at the beginning.
Than I changed the installer, so that you have some if-case for mysql or pgsql.
Finally I modified the templates for bootstrap and blueprint.

I hope, all will work.

Greetings

Jochen

root and others added 4 commits April 10, 2014 09:07
@demiankatz
Copy link
Member

Thanks, this looks like a great start. I'll test it out in the near future and let you know if I run into any issues.

@demiankatz
Copy link
Member

I've refactored this a bit to make it more generic, fixed a couple of bugs, corrected the SQL file encoding and checked that it works on my test server. Here's the revised commit: bcca1df

If you have time to try the latest code and make sure it still works for you, that would be a big help!

Also, a bigger project that might be worth thinking about down the road would be making the upgrade script PostgreSQL-friendly (though that's a much bigger and more difficult job, and perhaps not worth the effort).

@demiankatz demiankatz closed this Apr 29, 2014
@jochen-lienhard
Copy link
Contributor Author

Looks great .... it works perfect.

Demian Katz schrieb:

I've refactored this a bit to make it more generic, fixed a couple of
bugs, corrected the SQL file encoding and checked that it works on my
test server. Here's the revised commit: bcca1df
bcca1df

If you have time to try the latest code and make sure it still works
for you, that would be a big help!

Also, a bigger project that might be worth thinking about down the
road would be making the upgrade script PostgreSQL-friendly (though
that's a much bigger and more difficult job, and perhaps not worth the
effort).


Reply to this email directly or view it on GitHub
#143 (comment).

Dr. rer. nat. Jochen Lienhard
Dezernat EDV

Albert-Ludwigs-Universität Freiburg
Universitätsbibliothek
Rempartstr. 10-16 | Postfach 1629
79098 Freiburg | 79016 Freiburg

Telefon: +49 761 203-3908
E-Mail: lienhard@ub.uni-freiburg.de
Internet: www.ub.uni-freiburg.de

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants