FOLIO driver: add course reserves support #1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Still to do: address courses/departments/instructors correctly.
|
As of this writing, the course reserves features are functionally complete, but will probably not scale well due to the high volume of API calls needed to operate. |
crhallberg
approved these changes
Dec 16, 2019
demiankatz
force-pushed
the
folio-reserves
branch
from
e670c11
to
9e42c4d
Compare
|
Since the FOLIO Reserves API is not going to change in the immediate future, I am merging this as-is; we should revisit improving real-time lookup performance in future if the API evolves. @ihardy, if you have a chance, you may want to test the latest master code to make sure the combined merging of this PR and #1545 came out cleanly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also FOLIO ticket UXPROD-2140.
TODO