PHPStan configuration and basic fixes

[xmorave2]

This PR contains phing and travis configuration for running PHPStan checks on codebase and also fixes for level 0 of PHPStan analysis

TODO

• Integrate into Jenkins when merging

[demiankatz]

Thanks for this, @xmorave2! I've added a TODO to myself to hook this up with Jenkins when we merge it. I plan to merge many of your fixes to dev in advance of this full PR, which I think will make it easier to review what remains here. We may also want to discuss whether this complements or supersedes the work with Psalm in #1764. I'm not opposed to using multiple tools to maximize quality, but if one or the other is clearly better, it might make sense to choose. I'll add a more detailed review here once I've whittled things down by merging fixes.

[xmorave2]

@demiankatz From my point of view we could take this as complement to Psalm to maximize code quality. I would not say the one tool is better then the other one, both have their pluses and both are actively developed. Both are extensible, but only phpstan has plugin specific for laminas framework (but I don't try it yet, so maybe, we don't need it)

For me the PHPStan has more clear issues description. If we adopt the PHPStan I am ready to continue on fixing code for more strict rules.

[demiankatz]

Great, thank you again, @xmorave2, and I agree that the two tools will likely be complementary. I'll work with you on getting this finished up first since I think it is going to be less work than Psalm, and once we merge the fixes from this work into the Psalm branch, we will see what remaining issues are reported there.

[xmorave2]

Great, thanks @demiankatz

[demiankatz]

Thanks again for all of this work, @xmorave2 -- it's been tremendously helpful. I committed most of the fixes from here to the dev and release-7.1 branches, reducing this just to the actual PHPStan setup, and a few outstanding changes that I had questions about. In a few cases, I solved problems differently, but the vast majority of your work was carried through as-is. Hopefully it won't take too much more work to figure out the issues highlighted below, and then perhaps we can merge this!

[demiankatz]

Thanks again, @xmorave2, for all the work on this! I've incorporated the remaining fixes into the dev branch (some with minor adjustments, like refactoring of the UserCreationTrait to simplify matters), and I think this is now just about ready to merge. I'm going to be on vacation until April 6, so I am not going to merge it until after I get back -- but I hope to do it shortly thereafter, along with the necessary adjustments to use this in our Jenkins instance.

[demiankatz]

I've gotten clearance to remove the LBS4 driver, so I've gone ahead and done that to further simplify this PR. I'll look at Jenkins integration next; once that is figured out, we're ready to merge. Thanks again for your help!

[demiankatz]

I think I've taken care of the Jenkins integration; merging now to see how it goes! Now the question is if/when to start working on higher PHPStan levels. :-)