Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

de.ini: Fix incorrect translation of delete_account_description_html #1955

Closed
wants to merge 1 commit into from

Conversation

mtrojan-ub
Copy link
Contributor

No description provided.

@demiankatz
Copy link
Member

Thanks, @mtrojan-ub, since this is a fix, I have backported it to the release-7.1 branch and merged it to dev from there.

One note: it appears that you pushed this branch directly to the main vufind-org/vufind repository, instead of to your personal one. I suspect this was accidental, but you have this power now that you are a committer. It is not a problem, but I am trying to keep the branches in the main repository as clean/simple as possible, so I try to keep pull request branches outside to reduce clutter. In any case, I will delete this branch now that it has been merged!

@demiankatz demiankatz closed this May 14, 2021
@demiankatz demiankatz deleted the mtrojan_translation branch May 14, 2021 12:51
@mtrojan-ub
Copy link
Contributor Author

Thanks for merging! Sorry for the effort. Since this was a very minor change, instead of creating a new branch in our repository, i noticed that there was the possibility of using the edit mask directly on github and setting an option to create a branch there, which seemed to be the easier way to do it. In the view, there has been an option called "Create a new branch for this commit and start a pull request" which i haven't seen before, that's why i decided to try it out. Of course, if you would like to keep pull requests outside, i will go back to the old procedure & create a branch in our own repository in the future.

@demiankatz
Copy link
Member

Thanks for the explanation, @mtrojan-ub, that makes sense! If you have another simple fix in the future, and this approach saves you time, that's fine with me since I can merge these things quickly and delete the branches when done. As long as we don't create long-lived pull requests with a lot of discussion based on branches in the main repo, everything should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants