Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multi-level indenting #2180

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

aleksip
Copy link
Contributor

@aleksip aleksip commented Oct 20, 2021

@demiankatz This is just a suggestion, so feel free to close without merging if you don't think it is a good change.

Real life use case:

$sources['type'] == 'sectors'
    ? $this->translator
    ->translate('moderation_alert_sectors')
    : $this->translator
    ->translate('moderation_alert_databases'),

Could be indented like this:

$sources['type'] == 'sectors'
    ? $this->translator
        ->translate('moderation_alert_sectors')
    : $this->translator
        ->translate('moderation_alert_databases'),

The related PHP_CodeSniffer documentation has another example.

I understand that the goal is to deviate from the PEAR coding standards as little as possible, but I am not sure if this is covered by them? It seems to be more of a default choice in the PHP_CodeSniffer sniff.

@demiankatz
Copy link
Member

This makes sense to me -- thanks for the suggestion!

@demiankatz demiankatz merged commit 663087a into vufind-org:dev Oct 20, 2021
EreMaijala pushed a commit to EreMaijala/vufind that referenced this pull request Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants