Fix setting of language cookie. #2630
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EreMaijala
commented
Nov 17, 2022
EreMaijala
commented
- Overrides the cookie strategy to avoid it setting a cookie with wrong parameters.
- Only sets the language cookie if it doesn't already exist or match the detected language.
- Overrides the cookie strategy to avoid it setting a cookie with wrong parameters. - Only sets the language cookie if it doesn't already exist or match the detected language.
demiankatz
pushed a commit
that referenced
this pull request
Nov 18, 2022
- Overrides the cookie strategy to avoid it setting a cookie with wrong parameters. - Only sets the language cookie if it doesn't already exist or match the detected language.
demiankatz
approved these changes
Nov 18, 2022
There was a problem hiding this comment.
Thanks, @EreMaijala -- I've backported this to the release-8.1 branch and merged it from there to dev, so we can include it in our next bug fix release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.