BibTeX export fixes- added curly braces and a , after the citation key #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for sharing the fixes; I've manually merged this to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In BibTeX you have the option to use either curly braces or double quotes to enclose values. When I tested a record with an escaped double quote Zotero couldn't import it properly so I'm wrapping values in curly braces. That's the same as in the code Oliver shared:
https://github.com/swissbib/sbvf2/blob/master/themes/swissbib/templates/RecordDriver/AbstractBase/export-bibtex.phtml
I'm escaping the curly braces by doubling them (which is different than the code above) but I thought doubling them was a bit more readable.
Please let me know if there are any changes I should make to this. Thanks!