Allow deselecting a facet by clicking the facet value also in AND facets #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demiankatz
added a commit
that referenced
this pull request
Feb 19, 2015
Allow deselecting a facet by clicking the facet value also in AND facets
|
Makes perfect sense -- thanks! |
|
Just had a thought about this one: do you also use the top facet bar, or are you only using the side facets? It probably makes sense to add the same functionality to the top bar. Do you have time for this, or should I look into it? |
|
Good point. We don't use the top facet bar, so I'd appreciate if you could look into it. |
|
Thanks -- Chris or I will take care of it shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our usability studies showed that users expect they can toggle a facet on and off by clicking it. This already works for OR facets, but these changes allow delection of a facet by clicking it in the facet list also for AND facets.