Tweaked ICU workaround in SafeMoneyFormat to only touch LC_NUMERIC as th... #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the value of LC_ALL could become too long for setlocale() to handle in the end.
demiankatz
added a commit
that referenced
this pull request
Mar 12, 2015
Tweaked ICU workaround in SafeMoneyFormat to only touch LC_NUMERIC as th...
|
Works for me too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...e value of LC_ALL could become too long for setlocale() to handle in the end.
So I found out that the CentOS system our Jenkins runs on started to fail ("Specified locale name is too long") with the SafeMoneyFormat tweak because setlocale(LC_ALL, 0) returned a string over 255 chars long. This change should fix it while keeping the workaround working.