Relator-terms from German cataloguing guideline RAK #389
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demian, I have added the relator-terms from the German cataloguing guideline RAK to
author-classification.ini
.1.) The RAK-relator-terms come in upper and lower case form, plus the abbreviation ending with a
.
- as Solrmarc andauthor-modification.bsh
do not perform any string-manipulations on the MARC-Subfields 4/e and because of lower/upper case issues for RAK-relator-terms this could result in failures. One could reduce the list if one would transform the relator-terms to lower case and remove e.g. trailing.
2.) The RAK-relator-terms are commented out and in seperate lines - I think it would be best to keep the different sets of relator-terms in seperate blocks for maintenance reasons: e.g. if
getConfigSetting
(https://github.com/vufind-org/vufind/blob/improved-author-indexing/import/index_scripts/author-modification.bsh#L177) does support ini-arrays one could add the guideline-specific relator-terms as array-values.