Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added filter mechanism to combined search. #482

Merged
merged 1 commit into from
Oct 30, 2015
Merged

Conversation

demiankatz
Copy link
Member

  • Now you can provide multiple views into a single search backend.

@EreMaijala
Copy link
Contributor

Yay!

@demiankatz
Copy link
Member Author

Does this actually meet a use case for you, or are its limitations (namely, the fact that it doesn't easily translate into the tabbed search box) a significant problem? I'm trying to decide whether this is useful to commit as-is, or if deeper functionality needs to be implemented to make it richer. (Though if deeper functionality is needed, I have no brilliant ideas on how to do it cleanly).

@EreMaijala
Copy link
Contributor

We're not using a tabbed search box, only results, so that's not a limitation for us.

@demiankatz
Copy link
Member Author

Excellent. In that case, I'll definitely merge this sooner or later, but I'll probably leave the PR open for a couple of weeks in case I have any new ideas to expand/improve it (perhaps from brainstorming at the Summit). If you have any suggestions regarding configuration or code, they'd definitely be welcomed!

- Now you can provide multiple views into a single search backend.
@demiankatz
Copy link
Member Author

I've gone ahead and merged this to master. There's still room for better mechanisms elsewhere in VuFind, but this seems like a reasonable enhancement for CombinedController as it is.

@demiankatz demiankatz deleted the combined_filters branch January 6, 2016 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants