PSET: Add (de)serialization of WitnessUtxo's confidential fields #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiero
changed the title
tiero
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the TODOS left for serializing/deserializing the range and surjection proofs that might be contained in the
WitnessUtxofield of a partial input.Without this, when adding a confidential WitnessUtxo to an input with the updater's
AddInWitnessUtxo()method, the serialization of the pset will contain only the commitments of the utxo, missing the proofs.In the same way, when deserializing a WitnessUtxo that contains proofs, these isn't be deserialized causing the parsed WitnessUtxo to be incomplete.
@tiero please review this.