From confidential #138
Merged
From confidential #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the methods
FromBase58ConfidentialandToBase58Confidentialuseful for the user to parse confidential legay P2PKH and P2SH addresses, likeFromBlech32andToBlech32do for those bech32 confidentials.This also adds 2 new methods
FromConfidentialandToConfidentialthat help the user to convert an address from the confidential to the unconfidential format and viceversa.The last method added with this is
NetworkFromAddressthat is useful for knowing the network (either mainnet or regtest) an address refers to.In conclusion, this refactors the tests for the address package to increase order and readability, along with adding tests for the new methods mentioned above.
Please @tiero, review this.