Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests + Add support for asset re-issuance #144

Closed
wants to merge 7 commits into from

Conversation

altafan
Copy link
Collaborator

@altafan altafan commented Nov 19, 2020

This adds the support for creating transactions that re-issue asset.

BONUS:

  • integration tests have been refactored so that the signing and the finalization/extraction/broadcasting of the transaction take place respectively into signTransaction and broadcastTransaction, in the same way as the blinding is done into blindTransaction. This, in general, to increase reliability and to remove a lot of code repetions. We should do the same for the crafting of the tx.. maybe we could create some smart functions to avoid all the repetitions of the creation of inputs/outputs and keys.
  • remove nonsense integration tests and add more for different types of inputs.
  • fix functions of the address package that were expecting a network as arg instead of aclling NetworkForAddress (used also as validation check for the address in this way).
  • add missing tests for updater.AddIssuance method.

Closes #107.
Closes #112.
Closes #113.

Please @tiero, review this.

@altafan altafan closed this Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Pset] fix blinder to correctly blind a "reissuance" input issuance Asset reissuance
1 participant