Output descriptors: wpkh fragment support
#191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiero
reviewed
May 12, 2022
|
|
||
| "github.com/btcsuite/btcutil/hdkeychain" | ||
|
|
||
| "github.com/btcsuite/btcd/txscript" |
There was a problem hiding this comment.
I am afraid that for elements we should have a way to extends it since elements has more opcodes. For now it's fine tho
tiero
reviewed
May 12, 2022
| "github.com/btcsuite/btcutil/hdkeychain" | ||
|
|
||
| "github.com/btcsuite/btcd/txscript" | ||
| "github.com/btcsuite/btcutil" |
There was a problem hiding this comment.
shouldn't be github.com/btcsuite/btcd/btcutil now?
There was a problem hiding this comment.
we use github.com/btcsuite/btcutil in other pkg's, maybe we can treat this(replacing btcutil pkg everywhere) in another issue?
|
utACK for me @sekulicd , I would wait an actual implementation using this pkg before merging. You can test there requiring this commit directly |
tiero
changed the title
wpkh fragment support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds descriptor pkg with initial implementation for Wpkh descriptor wallet.
@tiero @altafan @louisinger please review.