Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup Schedule : pointers on fields #145

Merged
merged 2 commits into from
May 10, 2021
Merged

Conversation

ddymko
Copy link
Contributor

@ddymko ddymko commented May 10, 2021

Description

Backup Schedules allow the use of 0 as a valid field for Hour + Day of week. Changing these fields in the struct to be pointers to int.

Related Issues

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@ddymko ddymko added the bug Something isn't working label May 10, 2021
@ddymko ddymko requested a review from mamclaughlin May 10, 2021 12:20
@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #145 (3f14abf) into master (b1629b5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #145   +/-   ##
=======================================
  Coverage   54.43%   54.43%           
=======================================
  Files          23       23           
  Lines        1194     1194           
=======================================
  Hits          650      650           
  Misses        279      279           
  Partials      265      265           
Impacted Files Coverage Δ
instance.go 55.74% <ø> (ø)
govultr.go 90.69% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1629b5...3f14abf. Read the comment docs.

@ddymko ddymko merged commit 60eea9f into vultr:master May 10, 2021
@ddymko ddymko deleted the backups-fix branch May 10, 2021 14:02
@ddymko ddymko mentioned this pull request May 10, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants