This repository has been archived by the owner on Dec 2, 2019. It is now read-only.
Modify the appearance for option and checkbox! #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhouxs1023 <zhouxs1023@163.com>
dumblob
suggested changes
Mar 28, 2018
| @@ -15838,13 +15838,12 @@ nk_draw_checkbox(struct nk_command_buffer *out, | |||
|
|
|||
| /* draw background and cursor */ | |||
| if (background->type == NK_STYLE_ITEM_COLOR) { | |||
| nk_fill_rect(out, *selector, 0, style->border_color); | |||
| nk_fill_rect(out, nk_shrink_rect(*selector, style->border), 0, background->data.color); | |||
| nk_stroke_rect(out, *selector, 2, 2, background->data.color); | |||
There was a problem hiding this comment.
It's a total nitpicking, but this indentation is not correct 😉.
There was a problem hiding this comment.
I have looked at the codes ,It are correct! I had updated pics!
There was a problem hiding this comment.
The picture is totally fine. It's just, that this line is indented with tabs, but shall be indented with spaces. Otherwise I think this commit can get merged.
dumblob
suggested changes
Mar 30, 2018
| @@ -15838,13 +15838,12 @@ nk_draw_checkbox(struct nk_command_buffer *out, | |||
|
|
|||
| /* draw background and cursor */ | |||
| if (background->type == NK_STYLE_ITEM_COLOR) { | |||
| nk_fill_rect(out, *selector, 0, style->border_color); | |||
| nk_fill_rect(out, nk_shrink_rect(*selector, style->border), 0, background->data.color); | |||
| nk_stroke_rect(out, *selector, 2, 2, background->data.color); | |||
There was a problem hiding this comment.
The picture is totally fine. It's just, that this line is indented with tabs, but shall be indented with spaces. Otherwise I think this commit can get merged.
|
@zhouxs1023 could you change all the pictures in the main README.md file which show the radio buttons and are not using bitmap styling? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zhouxs1023 zhouxs1023@163.com
Modify the appearance for option and checkbox!