Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: image build args #73

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cylewitruk
Copy link

@cylewitruk cylewitruk commented Apr 4, 2024

What did you implement:

  • Adds support for buildargs argument when building an image. This is exposed on the ImageBuildOpts builder as build_args().
  • The default test Dockerfile content has been appended with an ARG which is used in tests.
  • Minor boyscouting (fixed a few warnings).

Closes: #72

How did you verify your change:

New test: image_create_with_build_args().
Also tested within my local app where I need this and it worked just fine.

What (if anything) would need to be called out in the CHANGELOG for the next release:

It's just a minor feature, but maybe good to add that it now works? (was a TODO previously).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] image build args
1 participant