-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utilize html5 for javascript selections #16
Comments
Marking this as a "question" since my intent is to get feedback if there are any opinions on this. I'll close it out within a week if there's no input. |
…elect change instead. Related to #16
I'm in favor of moving to html5 On Thu, Jun 25, 2015, 12:39 PM Scott Williams notifications@github.com
|
To be clear, this is anyway html5. We'd just be moving to using an html5
|
Some tasks, particularly events, use some tricky gymnastics to gather the necessary data to perform tasks, such as parsing out a parent id or class tag. This is reliable but not elegant and means at least some measure of code duplication between the events page and event detail pages.
Therefore, I'm considering utilizing html5 datasets to accomplish this instead: https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/Using_data_attributes
The downsides are that it will take time to test and recode, and that it will essentially break the app for IE10 and older (bonus?). The upsides are cleaner code and it will make the transition to a native app in Cordova much nicer.
The text was updated successfully, but these errors were encountered: