Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows compatibility broken by fcntl import #45

Closed
chriscline opened this issue Feb 13, 2019 · 2 comments
Closed

Windows compatibility broken by fcntl import #45

chriscline opened this issue Feb 13, 2019 · 2 comments

Comments

@chriscline
Copy link

The import fcntl line introduced in #43 broke Windows compatibility, since fcntl is not available on Windows. This import should probably be conditional on the platform.
@vxgmichel
Copy link
Owner

Ooops, I guess we really need to add some windows entries to our CI 😅

Thanks @chriscline for the report, I'll be releasing a new version today.

@vxgmichel vxgmichel mentioned this issue Feb 13, 2019
Merged
vxgmichel added a commit that referenced this issue Feb 13, 2019
@vxgmichel
Fix windows compatibility (PR #46, issue #45)
f3fc485
@vxgmichel
Copy link
Owner

Fixed with v0.1.13, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vxgmichel @chriscline