Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent exception in macOS with large output. #43

Merged
merged 2 commits into from
Feb 11, 2019

Conversation

gnachman
Copy link
Contributor

See issue #42.

On macOS 10.14, running a command in apython that produces a
lot of output (such as help(str)) causes BlockingIOError
to be raised by the call to dest.flush() in the wrap
function of rlwrap.py. Some unknown force is setting
O_NONBLOCK on the file descriptor.

See PR vxgmichel#42.

On macOS 10.14, running a command in apython that produces a
lot of output (such as `help(str)`) causes `BlockingIOError`
to be raised by the call to `dest.flush()` in the `wrap`
function of `rlwrap.py`. Some unknown force is setting
`O_NONBLOCK` on the file descriptor.
Copy link
Owner

@vxgmichel vxgmichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for investigating and making this PR!

aioconsole/rlwrap.py Outdated Show resolved Hide resolved
@vxgmichel
Copy link
Owner

Also please let me know if you need a new release :)

@adeadman
Copy link

adeadman commented Feb 10, 2019

A new release would be nice, at the moment I'm working around this by echoing large strings to a file/piping to the clipboard as the console will crash every time otherwise.

This is also affecting iTerm2 on macOS 10.13 as well, by the way - it's not limited to just the latest macOS.

@vxgmichel vxgmichel merged commit f748256 into vxgmichel:master Feb 11, 2019
@vxgmichel
Copy link
Owner

@adeadman Thanks for the report, v0.1.12 is out! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants