Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More links and details in the doc. #50

Merged
merged 2 commits into from
Dec 6, 2019
Merged

More links and details in the doc. #50

merged 2 commits into from
Dec 6, 2019

Conversation

blaiseli
Copy link
Contributor

@blaiseli blaiseli commented Nov 8, 2019

Attempts at improving the documentation following the discussion at #46

@blaiseli blaiseli mentioned this pull request Nov 8, 2019
Closed
@coveralls
Copy link

coveralls commented Nov 8, 2019 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 2c014e0 on blaiseli:doc_contrib into ab7bdd1 on vxgmichel:master.

vxgmichel
vxgmichel approved these changes Nov 9, 2019
View reviewed changes
Copy link
Owner

@vxgmichel vxgmichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good, thanks for fixing my typos and missing links ! :)
Is it ready to merge or do you want to add more changes?

@blaiseli
Copy link
Contributor Author

blaiseli commented Dec 5, 2019

Hi and sorry for not answering earlier. I won't have time to get back on this for the moment, so you can merge.

Thanks.

@vxgmichel vxgmichel merged commit f5e4278 into vxgmichel:master Dec 6, 2019
@vxgmichel
Copy link
Owner

Merged ! Thanks a lot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vxgmichel vxgmichel vxgmichel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@blaiseli @coveralls @vxgmichel