COMP: Address implicit long conversion warning #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To address:
/ITK/Modules/ThirdParty/VNL/src/vxl/core/vnl/vnl_numeric_traits.h:257:67: warning: implicit conversion from 'unsigned long long' to 'const long' changes value from 9223372036854775807 to -1 [-Wconstant-conversion]
static constexpr long maxval = sizeof(long)==8?(vxl_uint_64)(-1)/2:0x7fffffffL; // = 0x7fffffffL or 0x7fffffffffffffffL;
~~~~~~ ~~~~~~~~~~~~~~~~~^~
/ITK/Modules/ThirdParty/VNL/src/vxl/core/vnl/vnl_numeric_traits.h:278:70: warning: implicit conversion from 'vxl_uint_64' (aka 'unsigned long long') to 'const unsigned long' changes value from 18446744073709551615 to 4294967295 [-Wconstant-conversion]
static constexpr unsigned long maxval = sizeof(unsigned long)==8?((vxl_uint_64)(-1)):0xffffffffL ;
~~~~~~ ^~~~~~~~~~~~~~~~~
|
@hjmjohnson please take a look |
hjmjohnson
approved these changes
Dec 16, 2018
|
Thanks for the quick review / merge @hjmjohnson ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address:
/ITK/Modules/ThirdParty/VNL/src/vxl/core/vnl/vnl_numeric_traits.h:257:67: warning: implicit conversion from 'unsigned long long' to 'const long' changes value from 9223372036854775807 to -1 [-Wconstant-conversion]
static constexpr long maxval = sizeof(long)==8?(vxl_uint_64)(-1)/2:0x7fffffffL; // = 0x7fffffffL or 0x7fffffffffffffffL;
~~~~~~ ~~~~~~~~~~~~~~~~~^~
/ITK/Modules/ThirdParty/VNL/src/vxl/core/vnl/vnl_numeric_traits.h:278:70: warning: implicit conversion from 'vxl_uint_64' (aka 'unsigned long long') to 'const unsigned long' changes value from 18446744073709551615 to 4294967295 [-Wconstant-conversion]
static constexpr unsigned long maxval = sizeof(unsigned long)==8?((vxl_uint_64)(-1)):0xffffffffL ;
~~~~~~ ^~~~~~~~~~~~~~~~~