bridge: bugfixes for equuleus #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ces" (cherry picked from commit 99ff0ac)
Interface() base class already takes care about VLAN creation/removal of newly added or no longer required interfaces. No need to code this logic again. (cherry picked from commit 41477cc)
(cherry picked from commit 5422759)
... otherwise functionality like bridge VLANs will loose configuration on membe rinterface update (e.g. description) (cherry picked from commit a295ec1)
…y VLAN aware bridge (cherry picked from commit dbc8e24)
github-actions
bot
requested review from
dmbaturin,
jestabro,
DmitriyEshenko,
sever-sever and
zdc
… address
We should not print the entire dictionary - we only need the bridge interface
name:
Bug:
Cannot assign address to interface "eth1" as it is a member of bridge
"{'br0': {'allowed_vlan': ['5-50', '101'], 'native_vlan': '101'}}"!
Fixed:
Cannot assign address to interface "eth1" as it is a member of bridge
"br0"!
(cherry picked from commit 71f2f2d)
(cherry picked from commit a093598)
dmbaturin
approved these changes
Aug 3, 2022
sever-sever
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Bugfix VLAN aware bridges loose VLAN configuration on later changes to the lower e.g. eth1 interface. Also member interfaces can't be deleted completely if VLAN was enabled on a bridge
Types of changes
Related Task(s)
Component(s) name
bridge
Proposed changes
How to test
smoketests
Now change any setting on eth1 and
bridge -c vlan showstill must list eth1 with all it's VLANscpo@LR1.wue3# bridge -c vlan show port vlan-id eth1 5-50 101 PVID Egress Untagged br0 1 PVID Egress UntaggedChecklist: