Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openvpn: T4770: rewrite op-mode show/reset to use vyos.opmode #1699

Merged
merged 6 commits into from
Dec 12, 2022
Merged

openvpn: T4770: rewrite op-mode show/reset to use vyos.opmode #1699

merged 6 commits into from
Dec 12, 2022

Conversation

jestabro
Copy link
Contributor

@jestabro jestabro commented Dec 8, 2022

Change Summary

Rewrite openvpn show and reset functions to standardized form.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

openvpn

Proposed changes

How to test

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@jestabro jestabro self-assigned this Dec 8, 2022
@jestabro jestabro marked this pull request as draft December 8, 2022 13:44
@jestabro jestabro marked this pull request as ready for review December 8, 2022 14:20
@jestabro jestabro marked this pull request as draft December 10, 2022 21:06
@jestabro
Copy link
Contributor Author

Convert to draft to remove unnecessary 'routing_table_line' variable use; rebase over PR 1703.

@jestabro
vyos.util: T4770: add precision arg, fix typo in bytes_to_human
336576b 
This is useful in general, but we will add in this context to replace
the use of 'bytes2HR' in show_openvpn.py with util.bytes_to_human, while
maintaining compatability with original precision=1.
@jestabro jestabro marked this pull request as ready for review December 11, 2022 00:17
@jestabro jestabro merged commit 0c5416e into vyos:current Dec 12, 2022
@jestabro jestabro deleted the op-mode-openvpn branch December 14, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmbaturin dmbaturin dmbaturin approved these changes

@sarthurdev sarthurdev sarthurdev approved these changes

@sever-sever sever-sever sever-sever approved these changes

Assignees

@jestabro jestabro

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jestabro @dmbaturin @sarthurdev @sever-sever