Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T5017: Add interface ifbX to constraint interface-name #1845

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

sever-sever
Copy link
Member

Change Summary

Add interface ifbX to constraint interface-name

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

interface, ifb

Proposed changes

How to test

Before fix:

vyos@r14# set interfaces input ifb0
[edit]
vyos@r14# set interfaces ethernet eth0 redirect 'ifb0'

  Incorrect path /sys/class/net/ifb0: no such file or directory
  
  
  
  Invalid value
  Value validation failed
  Set failed

[edit]
vyos@r14# 

After fix:

vyos@r14# set interfaces input ifb0
[edit]
vyos@r14# set interfaces ethernet eth0 redirect 'ifb0'
[edit]
vyos@r14# 

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@vyosbot vyosbot requested review from a team and removed request for a team February 23, 2023 13:49
@dmbaturin dmbaturin merged commit ab16444 into vyos:current Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants