Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xml: T5854: clear empty paths left by embedded override of defaultValue #2679

Merged
merged 1 commit into from
Dec 24, 2023

Conversation

jestabro
Copy link
Contributor

Change Summary

For overriding defaultValue elements with XML fragments containing parent nodes, one needs to clean up leftover empty paths: example use case:

#include <include/accel-ppp/radius-additions.xml.i>
 <node name="radius">
   <children>
     <leafNode name="timeout">
       <defaultValue>30</defaultValue>
     </leafNode>
     <leafNode name="acct-timeout">
       <defaultValue>30</defaultValue>
     </leafNode>
   </children>
 </node>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@jestabro jestabro self-assigned this Dec 24, 2023
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, sever-sever and c-po and removed request for a team December 24, 2023 02:56
@c-po c-po merged commit 1856fd3 into vyos:current Dec 24, 2023
8 checks passed
@c-po
Copy link
Member

c-po commented Dec 24, 2023

@Mergifyio backport sagitta

Copy link

mergify bot commented Dec 24, 2023

backport sagitta

✅ Backports have been created

c-po added a commit that referenced this pull request Dec 24, 2023
xml: T5854: clear empty paths left by embedded override of defaultValue (backport #2679)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants