Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub: T6494: add workflow to build custom ISO for integration tests #3703

Merged
merged 1 commit into from
Jun 22, 2024
Merged

GitHub: T6494: add workflow to build custom ISO for integration tests #3703

merged 1 commit into from
Jun 22, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented Jun 21, 2024

Change Summary

For every PR we will build the vyos-1x package and include it in a custom build of the VyOS ISO image (generic flavor) in order to execute the commonly available smoketests:

  • make test (CLI smoketests)
  • make testc (config load & migration tests)
  • make testraid (Installation of RAID1 system with disk replacement)

This is a measure agains merged PRs that break the smoketests in the end.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): CI improvement

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@c-po c-po requested a review from a team as a code owner June 21, 2024 21:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 21, 2024 •
edited
Loading

👍
No issues in PR Title / Commit Title

@c-po c-po changed the title GitHub: add workflow to build custom ISO for integration tests GitHub: T6494: add workflow to build custom ISO for integration tests Jun 22, 2024
@c-po
GitHub: T6494: add workflow to build custom ISO for integration tests
fe25b78 
For every PR we will build the vyos-1x package and include it in a custom build
of the VyOS ISO image (generic flavor) in order to execute the commonly
available smoketests:

- make test (CLI smoketests)
- make testc (config load & migration tests)
- make testraid (Installation of RAID1 system with disk replacement)

This is a measure agains merged PRs that break the smoketests in the end.
@kumvijaya kumvijaya self-requested a review June 22, 2024 06:26
@dmbaturin dmbaturin merged commit 0c37a06 into vyos:current Jun 22, 2024
12 checks passed
@c-po c-po deleted the package-smoketest branch June 22, 2024 17:20
@c-po c-po mentioned this pull request Jun 24, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmbaturin dmbaturin dmbaturin approved these changes

@kumvijaya kumvijaya kumvijaya approved these changes

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev is a code owner automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc is a code owner automatically assigned from vyos/reviewers

@jestabro jestabro Awaiting requested review from jestabro jestabro is a code owner automatically assigned from vyos/reviewers

@sever-sever sever-sever Awaiting requested review from sever-sever sever-sever is a code owner automatically assigned from vyos/reviewers

Assignees

@c-po c-po

Labels
current
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c-po @dmbaturin @kumvijaya