Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6534: fix incorrect imports in vyos-config-encrypt.py #3743

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

BonusPlay
Copy link
Contributor

Change Summary

When executing command encryption enable, the command fails with:

Traceback (most recent call last):
  File "/usr/libexec/vyos/vyos-config-encrypt.py", line 29, in <module>
    from vyos.util import ask_input
ModuleNotFoundError: No module named 'vyos.util'

This is due to incorrect python imports (from vyos.util import ask_input instead of from vyos.utils.io import ask_input). This PR fixes this.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T6534

Related PR(s)

none

Component(s) name

encryption

Proposed changes

Fix incorrect python imports.

How to test

Execute encryption enable.

Smoketest result

There is no smoketest for this. I've build qemu-live image, here's the cmd output:

vyos@vyos:~$ encryption enable
WARNING: VyOS will boot into a default config when encrypted without a TPM
You will need to manually login with default credentials and use "encryption load"
to mount the encrypted volume and use "load /config/config.boot"

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

❌ VyOS CLI smoketests failed!

@BonusPlay
Copy link
Contributor Author

smoketests fail on test_ospf_14_segment_routing_configuration, which seems to be unrelated to this PR

@c-po c-po merged commit e270712 into vyos:current Jun 30, 2024
8 of 9 checks passed
@c-po
Copy link
Member

c-po commented Jun 30, 2024

@Mergifyio backport circinus

Copy link

mergify bot commented Jun 30, 2024

backport circinus

✅ Backports have been created

@c-po
Copy link
Member

c-po commented Jun 30, 2024

No backport for sagitta required, as it has no TPM functionality

c-po added a commit that referenced this pull request Jun 30, 2024
T6534: fix incorrect imports in vyos-config-encrypt.py (backport #3743)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants