Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6534: fix incorrect imports in vyos-config-encrypt.py (backport #3743) #3744

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 30, 2024

Change Summary

When executing command encryption enable, the command fails with:

Traceback (most recent call last):
  File "/usr/libexec/vyos/vyos-config-encrypt.py", line 29, in <module>
    from vyos.util import ask_input
ModuleNotFoundError: No module named 'vyos.util'

This is due to incorrect python imports (from vyos.util import ask_input instead of from vyos.utils.io import ask_input). This PR fixes this.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T6534

Related PR(s)

none

Component(s) name

encryption

Proposed changes

Fix incorrect python imports.

How to test

Execute encryption enable.

Smoketest result

There is no smoketest for this. I've build qemu-live image, here's the cmd output:

vyos@vyos:~$ encryption enable
WARNING: VyOS will boot into a default config when encrypted without a TPM
You will need to manually login with default credentials and use "encryption load"
to mount the encrypted volume and use "load /config/config.boot"

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

This is an automatic backport of pull request #3743 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner June 30, 2024 05:27
@mergify mergify bot requested review from dmbaturin, sarthurdev, zdc, jestabro, sever-sever and fett0 and removed request for a team June 30, 2024 05:27
Copy link

👍
No issues in PR Title / Commit Title

@c-po c-po enabled auto-merge June 30, 2024 05:47
@c-po c-po merged commit 134889f into circinus Jun 30, 2024
6 checks passed
@mergify mergify bot deleted the mergify/bp/circinus/pr-3743 branch June 30, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants