Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T973: add basic node_exporter implementation #4048

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

rebortg
Copy link
Member

@rebortg rebortg commented Sep 11, 2024

Change Summary

Implement basic node_exporter function

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T973

Related PR(s)

vyos/vyos-build#757

Component(s) name

node_exporter

Proposed changes

add new feature node_exporter with vrf support.

How to test

# use defaults:
set service monitoring node-exporter

# all config
set service monitoring node-exporter listen-address 10.10.10.1
set service monitoring node-exporter port 9999
set service monitoring node-exporter vrf mgmt

Smoketest result

vyos@vyos:~$ /usr/libexec/vyos/tests/smoke/cli/test_service_monitoring_node-exporter.py
test_01_basic_config (__main__.TestMonitoringNodeExporter.test_01_basic_config) ... ok

----------------------------------------------------------------------
Ran 1 test in 4.832s

OK

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Sep 11, 2024

👍
No issues in PR Title / Commit Title

Copy link

github-actions bot commented Sep 11, 2024

✅ No issues found in unused-imports check.. Please refer the workflow run

@rebortg rebortg force-pushed the node_exporter branch 2 times, most recently from f23fc7b to aba505a Compare September 11, 2024 12:48
@sever-sever
Copy link
Member

@rebortg
Copy link
Member Author

rebortg commented Oct 2, 2024

Probably requires to disable by default the service here https://github.com/vyos/vyos-build/blob/2b9303d0bd6b43bd92e2b2e9835a048877a63e11/data/live-build-config/hooks/live/18-enable-disable_services.chroot#L52

there is no service file in the node-exporter deb. The service file is create and delete by configure the feature

@sever-sever
Copy link
Member

there is no service file in the node-exporter deb. The service file is create and delete by configure the feature

For example, what will happen if I configure the service node exporter via VyOS CLI and reboot the router without saving?

@rebortg
Copy link
Member Author

rebortg commented Oct 3, 2024

there is no service file in the node-exporter deb. The service file is create and delete by configure the feature

For example, what will happen if I configure the service node exporter via VyOS CLI and reboot the router without saving?

good point. i tryed it.

the service file is present in /etc/systemd/system/ but it is not enabled for autostart and so the service is not started

Copy link

github-actions bot commented Oct 3, 2024

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests ❌ failed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

@c-po c-po merged commit a175bd6 into vyos:current Oct 4, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants