Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webproxy: T563: migrate from old Perl code to XML and get_config_dict() #643

Merged
merged 5 commits into from
Dec 28, 2020

Conversation

c-po
Copy link
Member

@c-po c-po commented Dec 12, 2020

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://phabricator.vyos.net/T563
https://docs.vyos.io/en/latest/configuration/service/webproxy.html

Component(s) name

webproxy

Proposed changes

  • Drop old Vyatta Perl implementation and go forward using XML and get_config_dict()

How to test

Integrated Smoketests or

set service webproxy listen-address 172.18.254.201 disable-transparent
set service webproxy authentication method ldap
set service webproxy authentication ldap base-dn "DC=vyos,DC=net"
set service webproxy authentication ldap username-attribute cn
set service webproxy authentication ldap bind-dn CN=proxyuser,CN=Users,DC=vyos,DC=net
set service webproxy authentication ldap filter-expression (cn=%s)
set service webproxy authentication ldap server ldap.vyos.net
set service webproxy authentication ldap use-ssl

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@c-po c-po marked this pull request as ready for review December 28, 2020 19:07
@c-po c-po merged commit 829e76f into vyos:current Dec 28, 2020
@c-po c-po deleted the t563-webproxy branch December 28, 2020 19:07
@dmbaturin
Copy link
Member

Great! One less legacy package!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants