Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

routing: T3211: Add redistribute protocol IS-IS to bgp ospf rip #739

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

sever-sever
Copy link
Member

Change Summary

Add option for redistribute protocol IS-IS to bgp/ospf/rip

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

T3211

Component(s) name

routing, bgp, ospf, rip, isis

Proposed changes

How to test

VyOS configuration:

set protocols bgp 65530 address-family ipv4-unicast redistribute isis
set protocols bgp 65530 neighbor 100.64.0.2 remote-as '65002'
set protocols ospf redistribute isis
set protocols rip interface eth1
set protocols rip redistribute isis

It should generate the next FRR configuration:

!
router rip
 network eth1
 redistribute isis
!
router bgp 65530
 no bgp ebgp-requires-policy
 no bgp network import-check
 neighbor 100.64.0.2 remote-as 65002
 !
 address-family ipv4 unicast
  redistribute isis
 exit-address-family
!
router ospf
 auto-cost reference-bandwidth 100
 timers throttle spf 200 1000 10000
 redistribute isis
!

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@c-po
Copy link
Member

c-po commented Feb 22, 2021

Please also extend the individual protocols smoketests by adding ISIS.

Example for BGP: https://github.com/vyos/vyos-1x/blob/current/smoketest/scripts/cli/test_protocols_bgp.py#L390-L391 but there is also a test for OSPF...

@sever-sever
Copy link
Member Author

Please also extend the individual protocols smoketests by adding ISIS.

Done

@c-po c-po merged commit 162f2f0 into vyos:current Feb 23, 2021
@sever-sever sever-sever deleted the T3211 branch March 4, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants