vyos-1x-vmware: T3681: don't bytecompile ether-resume.py #920
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exclude
/vmware-tools/scripts/
from bytecompilation to avoid the__pycache__
directory being created.Change Summary
This change avoids the bytecompilation of
ether-resume.py
by excluding the/vmware-tools/scripts/
path (regex).This effectively avoids creating the
/etc/vmware-tools/scripts/resume-vm-default.d/__pycache__
directory which causes errors/warnings when resuming a suspended VyOS in VMware.Types of changes
Related Task(s)
Component(s) name
vyos-1x-vmware
Proposed changes
This change avoids the byte compilation of the python scripts matching the path
/vmware-tools/scripts/
. This in turn prevents the__pycache__
directory creation. This directory conflicts with theopen-vm-tools
resume script as it does not handle directories.How to test
On VyOS-1.3.0-rc5, check the vyos-1x-vmware package (note the
__pycache__
directory):Then performed a build with the new Makefile to ensure the
vyos-1x-vmware
package doesn't have__pycache__
:Checklist: