Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T5086: Add Jenkins build for hsflowd deb pkg #320

Merged
merged 2 commits into from
Mar 16, 2023
Merged

Conversation

sever-sever
Copy link
Member

@sever-sever sever-sever commented Mar 14, 2023

Change Summary

Build hsflofd from sources
Disable hsflowd.service

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related PR

vyos/vyos-1x#1891

Related Task(s)

Component(s) name

sflow

Proposed changes

How to test

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro and c-po and removed request for a team March 14, 2023 18:55
@pavel-odintsov
Copy link

Great stuff. Nice approach to allow only pcap plugin.

I've replicated your build procedure with following configuration file:

sflow {
  DNSSD = off
  polling = 30
  agentIP = 127.0.0.1
  sampling.100M = 100
  sampling.1G   = 500
  sampling.10G  = 1000
  sampling.40G  = 4000
  sampling = 1000
  collector { ip = 127.0.0.1 udpport = 6343 }
  # Add all relevant interfaces to this list 
  pcap { dev = ens3 }
  pcap { dev = ens4 }
}

Then I feed pcap traffic to FastNetMon and it was parsed without any issues:

2023-03-15 14:42:27.321661 152.228.221.228:443 > 10.154.15.196:38292 protocol: tcp flags: ack frag: 0  packets: 1 size: 11334 bytes ip size: 11316 bytes ttl: 56 sample ratio: 1000  
2023-03-15 14:42:28.521203 152.228.221.228:443 > 10.154.15.196:38292 protocol: tcp flags: ack frag: 0  packets: 1 size: 22598 bytes ip size: 22580 bytes ttl: 56 sample ratio: 1000  
2023-03-15 14:42:28.521203 10.154.15.196:38292 > 152.228.221.228:443 protocol: tcp flags: ack frag: 0  packets: 1 size: 70 bytes ip size: 52 bytes ttl: 64 sample ratio: 1000  
2023-03-15 14:42:28.521203 152.228.221.228:443 > 10.154.15.196:38292 protocol: tcp flags: ack frag: 0  packets: 1 size: 53574 bytes ip size: 53556 bytes ttl: 56 sample ratio: 1000  
2023-03-15 14:42:28.521203 10.154.15.196:38292 > 152.228.221.228:443 protocol: tcp flags: ack frag: 0  packets: 1 size: 70 bytes ip size: 52 bytes ttl: 64 sample ratio: 1000  
2023-03-15 14:42:28.521203 10.154.15.196:38292 > 152.228.221.228:443 protocol: tcp flags: ack frag: 0  packets: 1 size: 70 bytes ip size: 52 bytes ttl: 64 sample ratio: 1000  
2023-03-15 14:42:29.120907 10.154.15.196:38292 > 152.228.221.228:443 protocol: tcp flags: ack frag: 0  packets: 1 size: 70 bytes ip size: 52 bytes ttl: 64 sample ratio: 1000  
2023-03-15 14:42:29.120907 10.154.15.196:38292 > 152.228.221.228:443 protocol: tcp flags: ack frag: 0  packets: 1 size: 70 bytes ip size: 52 bytes ttl: 64 sample ratio: 1000  
2023-03-15 14:42:29.120907 10.154.15.196:38292 > 152.228.221.228:443 protocol: tcp flags: ack frag: 0  packets: 1 size: 70 bytes ip size: 52 bytes ttl: 64 sample ratio: 1000  
2023-03-15 14:42:29.120907 152.228.221.228:443 > 10.154.15.196:38292 protocol: tcp flags: ack frag: 0  packets: 1 size: 56390 bytes ip size: 56372 bytes ttl: 56 sample ratio: 1000  
2023-03-15 14:42:30.320304 152.228.221.228:443 > 10.154.15.196:38292 protocol: tcp flags: ack frag: 0  packets: 1 size: 28230 bytes ip size: 28212 bytes ttl: 56 sample ratio: 1000  
2023-03-15 14:42:31.519681 10.154.15.196:38292 > 152.228.221.228:443 protocol: tcp flags: ack frag: 0  packets: 1 size: 70 bytes ip size: 52 bytes ttl: 64 sample ratio: 1000  
2023-03-15 14:42:31.519681 10.154.15.196:38292 > 152.228.221.228:443 protocol: tcp flags: ack frag: 0  packets: 1 size: 70 bytes ip size: 52 bytes ttl: 64 sample ratio: 1000  

sflow_hsflowd.zip

Everything works fine!

// and not via a DEB package
def pkgList = [
['name': 'hsflowd',
'scmCommit': 'v2.0.47-1',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump to v2.0.48-1 is needed.

@c-po c-po merged commit 0ef20a9 into vyos:current Mar 16, 2023
@sever-sever sever-sever deleted the T5086 branch March 17, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants