-
-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support the stateMutability field of the ABI JSON #1931
Comments
No, it looks this was missed in #1244. We can make this happen. |
@fubuloubu are there any updates on this? |
Not started yet, but it should be fairly easy to add if you want to give it a shot. We're planning on a release, hopefully in the next week or two. Appears there might be some work to determine |
Yes, shouldn't be hard to search for |
Previously stateMutability would not be interpreted The abi generation tests have been removed because they relied on ABIs generated with the deprecated ABI spec. Note: Vyper still hasn't updated vyperlang/vyper#1931
As of #2049 we can handle ABI inputs with either |
Do you support all the various states? And does the generated ABI JSON contain the |
@axic just to confirm, once we add the |
It is up to you. Solidity stopped outputting It seems it won't be detrimental if you stop outputting it, but I'm not entirely sure if there are frameworks specifically made for Vyper and if they depend on it (truffle, buidler, waffle should be fine). |
@iamdefinitelyahuman Brownie is okay with this, right? I think web3py handles this well |
Yeah, Brownie understands both formats. |
This has been briefly discussed in #1247 too.
Vyper still only outputs the
constant
andpayable
fields. ThestateMutability
field was introduced a while ago (probably 2 years ago?) to supersede bothconstant
andpayable
as well as to support more granularity:pure
view
nonpayable
payable
pure
means the function doesn't execute state modifying and neither state reading instructions;view
allows for state reading instructions;nonpayable
allows modifying the state, but no incoming ether transfer; andpayable
allows modifying the state and incoming ether transfers.It would be nice add support to Vyper to also output this field.
Are there any reasons against it?
The text was updated successfully, but these errors were encountered: