-
-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fully support ABIv2 State Mutability Field #2054
Fully support ABIv2 State Mutability Field #2054
Conversation
4544ae9
to
64358e9
Compare
Codecov Report
@@ Coverage Diff @@
## master #2054 +/- ##
==========================================
- Coverage 84.91% 84.37% -0.54%
==========================================
Files 83 83
Lines 8133 8129 -4
Branches 1967 1966 -1
==========================================
- Hits 6906 6859 -47
- Misses 738 773 +35
- Partials 489 497 +8
Continue to review full report at Codecov.
|
f7a9c57
to
773b219
Compare
Note: will try refactoring out |
f84da4c
to
54e01a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good. I really like that the interface logic moved into from_FunctionDef
, it's much easier to grok now.
Note to self: Once this merges, rename |
Co-authored-by: Ben Hauser <35276322+iamdefinitelyahuman@users.noreply.github.com>
Closes: #2042
Closes: #1931
What I did
modifying
tononpayable
in external interface definitionspayable
in external interface definitions (check forvalue=...
iffpayable
)payable
usagestateMutability
in ABI outputDescription for the changelog
modifying
tononpayable
in external interface definitionspayable
in external interface definitionsCute Animal Picture