Force users to initialize variables. #1597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fubuloubu
added
the
work in progress
Update tests, add ZERO_WEI enivonment var
|
Note to self: once this merges, update #1613 with |
|
Thanks to great contributions from @iamdefinitelyahuman , tests have been updated to pass after this new restriction. |
charles-cooper
changed the title
charles-cooper
removed
the
work in progress
fubuloubu
approved these changes
Sep 24, 2019
according to review comment Co-Authored-By: Bryant Eisenbach <fubuloubu@gmail.com>
This was referenced Sep 24, 2019
Merged
|
Waiting on review from one of @iamdefinitelyahuman, @jacqueswww or @davesque |
iamdefinitelyahuman
suggested changes
Sep 26, 2019
There was a problem hiding this comment.
There are a few issues in the tests that are passing because of #1624 or because the test was already expected to fail. Will fix.
Co-Authored-By: Ben Hauser <35276322+iamdefinitelyahuman@users.noreply.github.com>
Co-Authored-By: Ben Hauser <35276322+iamdefinitelyahuman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix #1493
How I did it
Disallow uninitialized variables
How to verify it
Description for the changelog
Disallow declaring variables without initialization
Cute Animal Picture