Allow environment variables and constants as default values #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fubuloubu
approved these changes
Sep 10, 2019
| @public | ||
| @payable | ||
| def foo(a: uint256(wei) = msg.value) -> bool: | ||
| self.xx = a |
There was a problem hiding this comment.
Do += here instead and call this twice in the test to show proper operation
fubuloubu
reviewed
Sep 10, 2019
| @@ -190,7 +190,7 @@ def bar() -> uint256(wei): | |||
| c.foo(transact={'value': 31337}) | |||
| assert c.bar() == 31337 | |||
| c.foo(666, transact={'value': 9001}) | |||
| assert c.bar() == 666 | |||
| assert c.bar() == 31337 + 666 | |||
There was a problem hiding this comment.
Maybe also add a line that says "balance of c contract is 31337 + 9001" to show the difference in using default args.
vyper/parser/expr.py
Outdated
| @@ -53,6 +53,23 @@ | |||
| string_to_bytes, | |||
| ) | |||
|
|
|||
| # var name: (lllnode, type) | |||
| BUILTIN_CONSTANTS = { | |||
| 'EMPTY_BYTES32': ([0], 'bytes32'), | |||
There was a problem hiding this comment.
style-wise I think the list constructor can be factored out here.
iamdefinitelyahuman
force-pushed
the
expanded-default-kwargs
branch
from
55e2dd5
to
7f5591f
Compare
|
LGTM |
charles-cooper
approved these changes
Sep 10, 2019
This was referenced Sep 24, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Allow builtin constants and environment variables to be used as defaults for keyword arguments - closes #1525
This does NOT allow custom constants.
How I did it
vyper/parser/expr.py- addedBUILTIN_CONSTANTSandENVIRONMENT_VARIABLESvyper/signatures/function_signature.py- add checks tovalidate_default_valuesHow to verify it
Run the updated tests.
Description for the changelog
Cute Animal Picture