Bounds checking in range() #1738
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add link to Gitcoin Grant for Github Sponsors Button
fubuloubu
reviewed
Nov 24, 2019
|
this needs to be rebased off master (and the stray commit removed) |
vyper/parser/stmt.py
Outdated
| if not SizeLimits.in_bounds(typ, val): | ||
| raise InvalidLiteralException('Invalid range value supplied', self.stmt) | ||
|
|
||
| def _get_outtype(self, arg0_expr: LLLnode, arg1_expr: LLLnode) -> str: |
There was a problem hiding this comment.
I think this code will be a lot clearer if this is called _get_range_type.
Co-Authored-By: Charles Cooper <cooper.charles.m@gmail.com>
|
@fubuloubu @charles-cooper made changes as suggested; I think it ready to be merged now? |
|
This pull request introduces 1 alert when merging eb9e5e2 into 391b251 - view on LGTM.com new alerts:
|
fubuloubu
reviewed
Dec 18, 2019
| @@ -570,7 +570,8 @@ def parse_for(self): | |||
| if num_of_args == 1: | |||
| arg0_expr = self._get_range_const_value_expr(arg0) | |||
| arg0_val = arg0_expr.value | |||
| out_type_str = arg0_expr.typ.typ | |||
| out_type = arg0_expr.typ | |||
| start = LLLnode.from_list(0, typ=out_type, pos=getpos(self.stmt)) | |||
| start = LLLnode.from_list(0, typ=out_type_str, pos=getpos(self.stmt)) | |||
|
Can we also rename |
|
Should be fixed by type checking work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Description for the changelog
Cute Animal Picture