Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement skip_contract_check kwarg #2551

Merged

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Dec 2, 2021

What I did

Implement #2550

How I did it

Pretty straightforward, thread the argument through typechecker and codegen

How to verify it

See tests

Description for the changelog

Add omit_contract_check kwarg as an external call option

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2021

Codecov Report

Merging #2551 (7ab7ab1) into master (2b96fd8) will increase coverage by 0.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2551      +/-   ##
==========================================
+ Coverage   85.65%   85.66%   +0.01%     
==========================================
  Files          90       90              
  Lines        9027     9036       +9     
  Branches     2324     2328       +4     
==========================================
+ Hits         7732     7741       +9     
  Misses        814      814              
  Partials      481      481              
Impacted Files Coverage Δ
vyper/__init__.py 81.81% <ø> (ø)
vyper/semantics/types/function.py 84.93% <71.42%> (+0.32%) ⬆️
vyper/old_codegen/external_call.py 94.64% <92.85%> (+0.30%) ⬆️
vyper/evm/opcodes.py 100.00% <0.00%> (ø)
vyper/compiler/utils.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b96fd8...7ab7ab1. Read the comment docs.

@charles-cooper
Copy link
Member Author

@transmissions11 up for review if you have any feedback before this gets merged

@transmissions11
Copy link
Contributor

omit_contract_check is a bit verbose but otherwise this looks great 👍

@charles-cooper
Copy link
Member Author

charles-cooper commented Dec 6, 2021

omit_contract_check is a bit verbose but otherwise this looks great +1

@transmissions11 any alternatives? open to suggestions

@transmissions11
Copy link
Contributor

no_code_check?

@charles-cooper
Copy link
Member Author

I think we are going to go with skip_contract_check. (contract instead of code because sometimes it's a check on returndatasize instead of extcodesize).

@charles-cooper charles-cooper changed the title feat: implement omit_contract_check kwarg feat: implement skip_contract_check kwarg Dec 8, 2021
@charles-cooper charles-cooper merged commit c060afb into vyperlang:master Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants