add all integer and bytes types #2705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2705 +/- ##
==========================================
- Coverage 86.98% 86.17% -0.82%
==========================================
Files 91 91
Lines 9846 9845 -1
Branches 2469 2465 -4
==========================================
- Hits 8565 8484 -81
- Misses 798 871 +73
- Partials 483 490 +7
Continue to review full report at Codecov.
|
charles-cooper
force-pushed
the
more_types
branch
2 times, most recently
from
550c4c1
to
bc6e7bd
Compare
charles-cooper
force-pushed
the
more_types
branch
from
32e01d5
to
d1d09bf
Compare
fubuloubu
reviewed
Mar 18, 2022
|
This pull request introduces 1 alert when merging d1d09bf into a125a88 - view on LGTM.com new alerts:
|
This commit adds all intN/uintN/bytesM types, bringing Vyper to full implementation of ABIv2 (technically in line with solidity as they do not have fixedMxN/ufixedMxN types). Practically speaking, these are the types that people will expect to be able to use. The implementation is a first pass. It generates the new types with Python dynamic class generation since the vyper/semantics type system has a 1:1 correspondence between Vyper and Python types. Future work should include a generous refactoring of the approach. Before release, we need to add more tests of arithmetic, and any builtin functions which accept integers and bytesM types.
fubuloubu
approved these changes
Mar 18, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
resolves #2559
Commit message
This commit adds all intN/uintN/bytesM types, bringing vyper to full
implementation of ABIv2 (technically in line with solidity as they do
not have fixedMxN/ufixedMxN types). Practically speaking, these are the
types that people will expect to be able to use.
The implementation is a first pass. It generates the new types with
Python dynamic class generation since the vyper/semantics type system
has a 1:1 correspondence between Vyper and Python types. Future work
should include a generous refactoring of the approach. Before release,
we need to add more tests of arithmetic, and any builtin functions which
accept integers and bytesM types.
Description for the changelog
Cute Animal Picture