-
-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change decimal bounds #2730
Change decimal bounds #2730
Conversation
34d17dc
to
37910c4
Compare
change from (-2**127 * 10**10, 2**127-1 * 10**10) to (-2**168, 2**168). this way we use the entire space, and clamps are more efficient and easier to reason about since we can use the same clamps as integers.
37910c4
to
c05deae
Compare
Codecov Report
@@ Coverage Diff @@
## master #2730 +/- ##
==========================================
- Coverage 87.25% 87.23% -0.03%
==========================================
Files 93 93
Lines 9896 9872 -24
Branches 2470 2465 -5
==========================================
- Hits 8635 8612 -23
- Misses 777 779 +2
+ Partials 484 481 -3
Continue to review full report at Codecov.
|
This pull request introduces 4 alerts when merging c05deae into ce6c5d7 - view on LGTM.com new alerts:
|
these were changed in #2730
What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture